]> Cypherpunks repositories - gostls13.git/commit
net: eliminate a deadlock on the failure path in TestNotTemporaryRead
authorBryan C. Mills <bcmills@google.com>
Fri, 22 Apr 2022 14:39:04 +0000 (10:39 -0400)
committerGopher Robot <gobot@golang.org>
Fri, 22 Apr 2022 21:27:09 +0000 (21:27 +0000)
commit8e1a9c34ab7ae73f6c7d6fad10a37f1738a1e86a
tree8f80e476d15872343a9e5d39c1b25fb4be6f2861
parent3e732411e5e0679af5375a3cbd84c41ef5cd2430
net: eliminate a deadlock on the failure path in TestNotTemporaryRead

This fixes a deadlock-on-failure that I probably introduced in
CL 385314.

This doesn't explain why the failure observed in #52492 occurred, but
it will at least give us more information to diagnose the failure if
it happens again. (The deadlock currently prevents the t.Fatal log
message from being written to the test's output.)

Fixes #52492.

Change-Id: I9e7874985e2820a6a4b703abe4f8e2035d5138c0
Reviewed-on: https://go-review.googlesource.com/c/go/+/401575
Run-TryBot: Bryan Mills <bcmills@google.com>
Auto-Submit: Bryan Mills <bcmills@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Ian Lance Taylor <iant@google.com>
src/net/net_test.go