]> Cypherpunks repositories - gostls13.git/commit
runtime: give the subprocess more time in TestSpuriousWakeupsNeverHangSemasleep
authorBryan C. Mills <bcmills@google.com>
Tue, 30 Nov 2021 21:10:47 +0000 (16:10 -0500)
committerBryan C. Mills <bcmills@google.com>
Wed, 1 Dec 2021 17:01:41 +0000 (17:01 +0000)
commit8ebb8c9ecba4069cc4defffffbbcdde0ba22ced1
tree9887561b5d94be94d1c15d49ab2dbd15b104f753
parent2c5d2083e41371aa4f5aab9e86921002c1f9b504
runtime: give the subprocess more time in TestSpuriousWakeupsNeverHangSemasleep

Issue #27250 reproduced readily enough to keep the subprocess hung
indefinitely when it occurred, so the timeout does not need to be
short to maintain test fidelity. On the other hand, on heavily loaded
systems it might take a while for the kernel to actually start the
subprocess, and it might also take a while for control flow to return
to the test after the subprocess exits.

We can reduce noise from this test in two ways:

1. Measure the timeout from closer to when the subprocess actually
starts sleeping, instead of when we started creating the subprocess.

2. Use a longer timeout, since it doesn't actually need to be short.

Fixes #38921
Updates #27250

Change-Id: I01c11ae82d0cdc6e7def2da6544b4d07201b35e8
Reviewed-on: https://go-review.googlesource.com/c/go/+/367849
Trust: Bryan C. Mills <bcmills@google.com>
Run-TryBot: Bryan C. Mills <bcmills@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Keith Randall <khr@golang.org>
src/runtime/semasleep_test.go