]> Cypherpunks repositories - gostls13.git/commit
cmd/compile/internal/types2: refactor untyped conversions
authorRobert Griesemer <gri@golang.org>
Thu, 18 Mar 2021 05:13:16 +0000 (22:13 -0700)
committerRobert Griesemer <gri@golang.org>
Tue, 23 Mar 2021 05:11:09 +0000 (05:11 +0000)
commit8f19394b62a5b1651cd66eefb1bfeacc278966b9
treeaf9e7e1c97239a9283eedd30c49f437e4acb054d
parent0265b6475f08f2c23a742132db87c357fcbfa458
cmd/compile/internal/types2: refactor untyped conversions

Based on https://golang.org/cl/284256 for go/types.
Brings this code more in line with go/types.

Adjusted various tests to match new error messages which
generally are now better: for assignment errors, instead
of a generic "cannot convert" we now say "cannot use"
followed by a clearer reason as to why not.

Major differences to go/types with respect to the changed
files:

- Some of the new code now returns error codes, but they
  are only used internally for now, and not reported with
  errors.

- go/types does not "convert" untyped nil values to target
  types, but here we do. This is unchanged from how types2
  handled this before this CL.

Change-Id: If45336d7ee679ece100f6d9d9f291a6ea55004d8
Reviewed-on: https://go-review.googlesource.com/c/go/+/302757
Trust: Robert Griesemer <gri@golang.org>
Reviewed-by: Robert Findley <rfindley@google.com>
23 files changed:
src/cmd/compile/internal/types2/api.go
src/cmd/compile/internal/types2/assignments.go
src/cmd/compile/internal/types2/builtins.go
src/cmd/compile/internal/types2/call.go
src/cmd/compile/internal/types2/conversions.go
src/cmd/compile/internal/types2/examples/methods.go2
src/cmd/compile/internal/types2/expr.go
src/cmd/compile/internal/types2/operand.go
src/cmd/compile/internal/types2/testdata/builtins.src
src/cmd/compile/internal/types2/testdata/constdecl.src
src/cmd/compile/internal/types2/testdata/decls2/decls2b.src
src/cmd/compile/internal/types2/testdata/expr3.src
src/cmd/compile/internal/types2/testdata/issues.src
src/cmd/compile/internal/types2/testdata/stmt0.src
src/cmd/compile/internal/types2/testdata/typeparams.go2
test/convlit.go
test/fixedbugs/bug205.go
test/fixedbugs/bug397.go
test/fixedbugs/issue11326.go
test/fixedbugs/issue11371.go
test/fixedbugs/issue13559.go
test/fixedbugs/issue6402.go
test/fixedbugs/issue7153.go