]> Cypherpunks repositories - gostls13.git/commit
cmd/compile: fix bug with Inferred targs
authorDan Scales <danscales@google.com>
Sun, 29 Aug 2021 13:49:28 +0000 (06:49 -0700)
committerDan Scales <danscales@google.com>
Mon, 30 Aug 2021 21:22:35 +0000 (21:22 +0000)
commit8f4c020660d4c8a7bab9a7363551d07176e638eb
tree6492dead38203f0fe018b9853f60ef56b8398e34
parent8250141c9a506dee883b53473867b27e68ac10a4
cmd/compile: fix bug with Inferred targs

We were using the type from the wrong Node (the partially filled-in
FUNCINST) rather than the original function node - which is pointed to
by the OFUNCINST)) to set the final fully-substituted type of the
OFUNCINST. So fixed the node reference. Also, added check so we don't do
any work at all if the OFUNCINST already has all type args filled in.

Added few extra cases to the test file issue48030.go, to cover
fully-specified type args, partially inferred type args, and fully
inferred type args.

Fixes #48030

Change-Id: If9e4f2e0514d68b9d241f30c423259133932b25b
Reviewed-on: https://go-review.googlesource.com/c/go/+/346229
Trust: Dan Scales <danscales@google.com>
Run-TryBot: Dan Scales <danscales@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Keith Randall <khr@golang.org>
src/cmd/compile/internal/noder/expr.go
test/typeparam/issue48030.go [new file with mode: 0644]