]> Cypherpunks repositories - gostls13.git/commit
cmd/go: replace a.Package.Internal.Pkgfile with a.built
authorRuss Cox <rsc@golang.org>
Thu, 5 Oct 2017 20:57:25 +0000 (16:57 -0400)
committerRuss Cox <rsc@golang.org>
Wed, 11 Oct 2017 17:47:12 +0000 (17:47 +0000)
commit8f7f46f5a6d9fe821494aca3c689ca2572a42b41
tree8745517688cc6706f046dd0b5c274b2db094bf89
parent12ec54724bcb016a70bcafa1bfc1d8f411fbfe74
cmd/go: replace a.Package.Internal.Pkgfile with a.built

Logically the build needs to start treating a.Package as immutable,
since we might want to build a.Package multiple ways.
Record the built target in a.built instead.

Right now a.built is predictable ahead of time, but we want to
move toward satisfying some builds from a cache directory,
in which case a.built will point into the cache directory
and not be determined until action execution time.

There is probably more to do with shared libraries, but this
does not break what's there.

Change-Id: I941988b520bee2f664fd8cabccf389e1dc29628b
Reviewed-on: https://go-review.googlesource.com/69050
Run-TryBot: Russ Cox <rsc@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: David Crawshaw <crawshaw@golang.org>
src/cmd/go/internal/load/pkg.go
src/cmd/go/internal/work/build.go