]> Cypherpunks repositories - gostls13.git/commit
cmd/trace/v2: add support for a task-oriented procs-based view
authorMichael Anthony Knyszek <mknyszek@google.com>
Mon, 20 Nov 2023 05:37:36 +0000 (05:37 +0000)
committerMichael Knyszek <mknyszek@google.com>
Tue, 21 Nov 2023 21:29:50 +0000 (21:29 +0000)
commit90ba4452530f7a380e7fb4936569f53879fd5955
tree810f3377c1a60ec95aeb902cee8a7710cc7e8024
parent64c12bafea06144c0d4e3f3bee80171021800903
cmd/trace/v2: add support for a task-oriented procs-based view

This change implements support for the trace?focustask=<taskid> endpoint
in the trace tool for v2 traces.

Note: the one missing feature in v2 vs. v1 is that the "irrelevant" (but
still rendered) events are not grayed out. This basically includes
events that overlapped with events that overlapped with other events
that were in the task time period, but aren't themselves directly
associated. This is probably fine -- the UI already puts a very obvious
focus on the period of time the selected task was running.

For #60773.
For #63960.

Change-Id: I5c78a220ae816e331b74cb67c01c5cd98be40dd4
Reviewed-on: https://go-review.googlesource.com/c/go/+/543596
Auto-Submit: Michael Knyszek <mknyszek@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Michael Pratt <mpratt@google.com>
src/cmd/trace/trace.go
src/cmd/trace/v2/gen.go
src/cmd/trace/v2/goroutinegen.go
src/cmd/trace/v2/gstate.go
src/cmd/trace/v2/jsontrace.go
src/cmd/trace/v2/procgen.go
src/internal/trace/summary.go
src/internal/trace/traceviewer/emitter.go