]> Cypherpunks repositories - gostls13.git/commit
[release-branch.go1.25] encoding/pem: make Decode complexity linear
authorRoland Shoemaker <bracewell@google.com>
Tue, 30 Sep 2025 18:16:56 +0000 (11:16 -0700)
committerMichael Pratt <mpratt@google.com>
Tue, 7 Oct 2025 18:04:16 +0000 (11:04 -0700)
commit90f72bd5001d0278949fab0b7a40f7d8c712979b
tree7e03f9308d4c2cea284734dd43965356a3995635
parente0f655bf3f96410f90756f49532bc6a1851855ca
[release-branch.go1.25] encoding/pem: make Decode complexity linear

Because Decode scanned the input first for the first BEGIN line, and
then the first END line, the complexity of Decode is quadratic. If the
input contained a large number of BEGINs and then a single END right at
the end of the input, we would find the first BEGIN, and then scan the
entire input for the END, and fail to parse the block, so move onto the
next BEGIN, scan the entire input for the END, etc.

Instead, look for the first END in the input, and then the first BEGIN
that precedes the found END. We then process the bytes between the BEGIN
and END, and move onto the bytes after the END for further processing.
This gives us linear complexity.

Fixes CVE-2025-61723
For #75676
Fixes #75709

Change-Id: I813c4f63e78bca4054226c53e13865c781564ccf
Reviewed-on: https://go-internal-review.googlesource.com/c/go/+/2921
Reviewed-by: Nicholas Husin <husin@google.com>
Reviewed-by: Damien Neil <dneil@google.com>
Reviewed-on: https://go-internal-review.googlesource.com/c/go/+/2985
Reviewed-on: https://go-review.googlesource.com/c/go/+/709851
Reviewed-by: Carlos Amedee <carlos@golang.org>
Auto-Submit: Michael Pratt <mpratt@google.com>
TryBot-Bypass: Michael Pratt <mpratt@google.com>
src/encoding/pem/pem.go
src/encoding/pem/pem_test.go