]> Cypherpunks repositories - gostls13.git/commit
cmd/compile: prevent memmove in copy when dst == src
authorJosh Bleecher Snyder <josharian@gmail.com>
Thu, 15 Feb 2018 03:05:36 +0000 (19:05 -0800)
committerJosh Bleecher Snyder <josharian@gmail.com>
Wed, 28 Feb 2018 17:37:22 +0000 (17:37 +0000)
commit91a05b92bedc976009b967d3e3bcbbe6353eb4a6
tree6ce8cf8e06daa2efa58f1d7f12733d1a41dd4f2a
parenta379b7d9acd69cd4a23eec7d7409084e15f8ace0
cmd/compile: prevent memmove in copy when dst == src

This causes a nominal increase in binary size.

name        old object-bytes  new object-bytes  delta
Template          399kB ± 0%        399kB ± 0%    ~     (all equal)
Unicode           207kB ± 0%        207kB ± 0%    ~     (all equal)
GoTypes          1.23MB ± 0%       1.23MB ± 0%    ~     (all equal)
Compiler         4.35MB ± 0%       4.35MB ± 0%  +0.01%  (p=0.008 n=5+5)
SSA              9.77MB ± 0%       9.77MB ± 0%  +0.00%  (p=0.008 n=5+5)
Flate             236kB ± 0%        236kB ± 0%  +0.04%  (p=0.008 n=5+5)
GoParser          298kB ± 0%        298kB ± 0%    ~     (all equal)
Reflect          1.03MB ± 0%       1.03MB ± 0%  +0.01%  (p=0.008 n=5+5)
Tar               333kB ± 0%        334kB ± 0%  +0.22%  (p=0.008 n=5+5)
XML               414kB ± 0%        414kB ± 0%  +0.02%  (p=0.008 n=5+5)
[Geo mean]        730kB             731kB       +0.03%

Change-Id: I381809fd9cfbfd6db44bd342b06285e62a3a21f1
Reviewed-on: https://go-review.googlesource.com/94596
Run-TryBot: Josh Bleecher Snyder <josharian@gmail.com>
Reviewed-by: Keith Randall <khr@golang.org>
src/cmd/compile/internal/gc/walk.go