]> Cypherpunks repositories - gostls13.git/commit
cmd/compile: fix unsafe.Add with small-size offsets operands
authorMatthew Dempsky <mdempsky@google.com>
Wed, 22 Sep 2021 22:56:58 +0000 (15:56 -0700)
committerMatthew Dempsky <mdempsky@google.com>
Thu, 23 Sep 2021 00:14:22 +0000 (00:14 +0000)
commit93453233bd00cc641d2f959f1faf236e0094c2bf
treea2d8297c3b0e47f2614456d671a2a36e14439354
parentee69b09424f611d02d4b0f0da3eff875e075438f
cmd/compile: fix unsafe.Add with small-size offsets operands

Like other builtin functions, unsafe.Add's len operand is allowed to
be variable sized. However, unlike other builtins, it doesn't get
lowered to a runtime function call, so we never end up coercing it to
a specific type. As a result, we could end up constructing an OpAddPtr
value but with a less-than-ptr-sized addend operand.

This CL fixes this by always coercing the second operand to uintptr
during SSA construction.

Theoretically, we could do this during walk instead, but the frontend
doesn't allow converting negative constants to uintptr.

Fixes #48536.

Change-Id: Ib0619ea79df58b256b250fec967a6d3c8afea631
Reviewed-on: https://go-review.googlesource.com/c/go/+/351592
Trust: Matthew Dempsky <mdempsky@google.com>
Run-TryBot: Matthew Dempsky <mdempsky@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Cuong Manh Le <cuong.manhle.vn@gmail.com>
src/cmd/compile/internal/ssagen/ssa.go
test/fixedbugs/issue48536.go [new file with mode: 0644]