]> Cypherpunks repositories - gostls13.git/commit
[release-branch.go1.24] os/exec: fix incorrect expansion of ".." in LookPath on plan9
authorRichard Miller <millerresearch@gmail.com>
Thu, 7 Aug 2025 10:15:23 +0000 (11:15 +0100)
committerCherry Mui <cherryyz@google.com>
Mon, 25 Aug 2025 18:16:04 +0000 (11:16 -0700)
commit94ca1d97b4520cafc377110712b77e4cecc64c12
treefb49af9c3a728779351d8374c30f3ca9e124f4f5
parentfe83d4bcad745b5173185025bb88ac78dd980dc3
[release-branch.go1.24] os/exec: fix incorrect expansion of ".." in LookPath on plan9

The correction in CL 685755 is incomplete for plan9, where path
search is performed even on file strings containing "/". By
applying filepath.Clean to the argument of validateLookPath,
we can check for bogus file strings containing ".." where the
later call to filepath.Join would transform a path like
"badfile/dir/.." to "badfile" even where "dir" isn't a directory
or doesn't exist.

For #74466
Fixes #75007

Change-Id: I3f8b73a1de6bc7d8001b1ca8e74b78722408548e
Reviewed-on: https://go-review.googlesource.com/c/go/+/693935
Reviewed-by: David du Colombier <0intro@gmail.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: David Chase <drchase@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
(cherry picked from commit 674c5f0edd82b5d1dd5cb44eb4b85830245c151e)
Reviewed-on: https://go-review.googlesource.com/c/go/+/698655
TryBot-Bypass: Cherry Mui <cherryyz@google.com>
Reviewed-by: Cherry Mui <cherryyz@google.com>
src/os/exec/lp_plan9.go