]> Cypherpunks repositories - gostls13.git/commit
cmd/compile: add column details to export data
authorMatthew Dempsky <mdempsky@google.com>
Mon, 23 Sep 2019 21:25:22 +0000 (14:25 -0700)
committerMatthew Dempsky <mdempsky@google.com>
Fri, 27 Sep 2019 18:38:37 +0000 (18:38 +0000)
commit95b8cbfee93766274583bacfb98b3b0cc1dbb6cf
tree78caf3ba1f4a3ebc7ec5fad043c54bc868d6f6c1
parent683ef8c8441d100590f5ed5c9d662e217a7130ce
cmd/compile: add column details to export data

This CL updates the export data format to include column details when
writing out position data. cmd/compile is updated to generate and make
use of the new details, but go/internal/gcimporter only knows how to
read the data. It doesn't yet actually make use of it.

Experimentally across a wide range of packages, this increases export
data size by around 4%. However, it has no impact on binary size.
(Notably, it actually shrinks k8s.io/kubernetes/cmd/kubelet's binary
size by 24kB, but it's unclear to me why at this time.)

Updates #28259.

Change-Id: I351fb340839df8d3adced49b3757c4537fb91b3f
Reviewed-on: https://go-review.googlesource.com/c/go/+/196963
Run-TryBot: Matthew Dempsky <mdempsky@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Robert Griesemer <gri@golang.org>
Reviewed-by: Rob Pike <r@golang.org>
src/cmd/compile/internal/gc/iexport.go
src/cmd/compile/internal/gc/iimport.go
src/go/internal/gcimporter/bimport.go
src/go/internal/gcimporter/iimport.go