]> Cypherpunks repositories - gostls13.git/commit
cmd/link: correctly decode name length
authorDavid Crawshaw <crawshaw@golang.org>
Tue, 26 Apr 2016 14:53:25 +0000 (10:53 -0400)
committerDavid Crawshaw <crawshaw@golang.org>
Tue, 26 Apr 2016 15:55:06 +0000 (15:55 +0000)
commit96b8f70e22e103c11fbb89ba6df9d229d24cdbc2
tree37ff3c0b7efcb765c56229347d0f5253df3a95ea
parent0b6332eb54767f916926ae39516ddaed87b26edb
cmd/link: correctly decode name length

The linker was incorrectly decoding type name lengths, causing
typelinks to be sorted out of order and in cases where the name was
the exact right length, linker panics.

Added a test to the reflect package that causes TestTypelinksSorted
to fail before this CL. It's not the exact failure seen in #15448
but it has the same cause: decodetype_name calculating the wrong
length.

The equivalent decoders in reflect/type.go and runtime/type.go
have the parenthesis in the right place.

Fixes #15448

Change-Id: I33257633d812b7d2091393cb9d6cc8a73e0138c8
Reviewed-on: https://go-review.googlesource.com/22403
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
Reviewed-by: Russ Cox <rsc@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
src/cmd/link/internal/ld/decodesym.go
src/reflect/all_test.go