]> Cypherpunks repositories - gostls13.git/commit
cmd/asm, cmd/compile: optimize math.Abs and math.Copysign on s390x
authorMichael Munday <mike.munday@ibm.com>
Fri, 27 Oct 2017 13:45:45 +0000 (09:45 -0400)
committerMichael Munday <mike.munday@ibm.com>
Mon, 30 Oct 2017 23:42:51 +0000 (23:42 +0000)
commit96cdacb9717271126eb60de3d8410c9cecd67b28
tree49eba8ac93d1d88fa7dc826df47afb8bf523a9e0
parent7fff1db0605739fee20673475cbc1813fdf7008e
cmd/asm, cmd/compile: optimize math.Abs and math.Copysign on s390x

This change adds three new instructions:

- LPDFR: load positive (math.Abs(x))
- LNDFR: load negative (-math.Abs(x))
- CPSDR: copy sign (math.Copysign(x, y))

By making use of GPR <-> FPR moves we can now compile math.Abs and
math.Copysign to these instructions using SSA rules.

This CL also adds new rules to merge address generation into combined
load operations. This makes GPR <-> FPR move matching more reliable.

name                 old time/op  new time/op  delta
Copysign             1.85ns ± 0%  1.40ns ± 1%  -24.65%  (p=0.000 n=8+10)
Abs                  1.58ns ± 1%  0.73ns ± 1%  -53.64%  (p=0.000 n=10+10)

The geo mean improvement for all math package benchmarks was 4.6%.

Change-Id: I0cec35c5c1b3fb45243bf666b56b57faca981bc9
Reviewed-on: https://go-review.googlesource.com/73950
Run-TryBot: Michael Munday <mike.munday@ibm.com>
Reviewed-by: Keith Randall <khr@golang.org>
src/cmd/asm/internal/asm/testdata/s390x.s
src/cmd/compile/internal/gc/asm_test.go
src/cmd/compile/internal/s390x/ssa.go
src/cmd/compile/internal/ssa/gen/S390X.rules
src/cmd/compile/internal/ssa/gen/S390XOps.go
src/cmd/compile/internal/ssa/opGen.go
src/cmd/compile/internal/ssa/rewriteS390X.go
src/cmd/internal/obj/s390x/a.out.go
src/cmd/internal/obj/s390x/anames.go
src/cmd/internal/obj/s390x/asmz.go