]> Cypherpunks repositories - gostls13.git/commit
cmd/asm, go/build: invoke cmd/asm only once per package
authorJosh Bleecher Snyder <josharian@gmail.com>
Wed, 18 May 2016 20:27:11 +0000 (13:27 -0700)
committerJosh Bleecher Snyder <josharian@gmail.com>
Wed, 24 Aug 2016 22:31:34 +0000 (22:31 +0000)
commit9741d83ceaf046e55077d68719cc2781cd96d5f1
tree799ab41bfbd69ce2d6d863d10f32925c6836b8e1
parent9d4623fe43f121bd98cdb78f207aa12bfc68dbc2
cmd/asm, go/build: invoke cmd/asm only once per package

Prior to this CL, cmd/go invoked cmd/asm once
for every assembly file.
The exec and cmd/asm startup overhead dwarfed
the actual time spent assembling.
This CL adds support to cmd/asm to process
multiple input files and uses it in cmd/go.

This cuts 10% off the wall time for 'go build -a math'.

Fixes #15680

Change-Id: I12d2ee2c817207954961dc8f37b8f2b09f835550
Reviewed-on: https://go-review.googlesource.com/27636
Run-TryBot: Josh Bleecher Snyder <josharian@gmail.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Rob Pike <r@golang.org>
src/cmd/asm/internal/flags/flags.go
src/cmd/asm/main.go
src/cmd/go/build.go