]> Cypherpunks repositories - gostls13.git/commit
cmd/go: if -race, don't run coverage on runtime packages
authorIan Lance Taylor <iant@golang.org>
Sat, 17 Feb 2018 03:08:59 +0000 (19:08 -0800)
committerIan Lance Taylor <iant@golang.org>
Tue, 27 Mar 2018 22:41:14 +0000 (22:41 +0000)
commit976a852d4c26b80f4084151c36f3024c180aa3b9
tree080870e3eed2ac36dcec5755abf9e4d8689f880f
parentbd18c09095ed432f9638b3b1181b3c5390c8c51c
cmd/go: if -race, don't run coverage on runtime packages

Don't compile the runtime packages with coverage when using the race
detector. The user can, perhaps accidentally, request coverage for the
runtime by using -coverpkg=all. If using the race detector, the
runtime package coverage will call into the race detector before it
has been initialized. This will cause the program to crash
mysteriously on startup.

Fixes #23882

Change-Id: I9a63867a9138797d8b8afb0856ae21079accdb27
Reviewed-on: https://go-review.googlesource.com/94898
Run-TryBot: Ian Lance Taylor <iant@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Andrew Bonventre <andybons@golang.org>
src/cmd/go/go_test.go
src/cmd/go/internal/test/test.go