]> Cypherpunks repositories - gostls13.git/commit
cmd/compile: re-enable nilcheck removal in same block
authorCherry Zhang <cherryyz@google.com>
Fri, 20 Jan 2017 15:38:05 +0000 (10:38 -0500)
committerCherry Zhang <cherryyz@google.com>
Fri, 17 Feb 2017 19:19:59 +0000 (19:19 +0000)
commit98061fa5f3a2410c97625cf5eb5a2cd8816bb558
tree2af5cba29f508158089747ce188e7ffc53b74d85
parent81acd308a4577af3f0c3e191b16e125c5d10bbf4
cmd/compile: re-enable nilcheck removal in same block

Nil check removal in the same block is disabled due to issue 18725:
because the values are not ordered, a nilcheck may influence a
value that is logically before it. This CL re-enables same-block
nilcheck removal by ordering values in store order first.

Updates #18725.

Change-Id: I287a38525230c14c5412cbcdbc422547dabd54f6
Reviewed-on: https://go-review.googlesource.com/35496
Run-TryBot: Cherry Zhang <cherryyz@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: David Chase <drchase@google.com>
src/cmd/compile/internal/ssa/nilcheck.go
test/nilptr3.go