]> Cypherpunks repositories - gostls13.git/commit
cmd/link: don't include deadcoded function symbols in shared build mode
authorCherry Mui <cherryyz@google.com>
Fri, 24 May 2024 22:04:11 +0000 (18:04 -0400)
committerCherry Mui <cherryyz@google.com>
Fri, 7 Jun 2024 14:52:41 +0000 (14:52 +0000)
commit98529a8e7cf1cc0b561f26a4bd3ddf8f6dbd2f8a
tree55602989c8923e4d9407aa7e78f6e714dd60dd9c
parentf7c330eac7777612574d8a1652fd415391f6095e
cmd/link: don't include deadcoded function symbols in shared build mode

In shared build mode, we include all symbols. This includes
function symbols that are deadcoded by the compiler. They don't
really get compiled, and their metadata may be missing, causing
linker failures. Skip them.

Fixes #67635.

Change-Id: Ic0e64bd032be499cca26da5e9e3ffbe9998bac05
Reviewed-on: https://go-review.googlesource.com/c/go/+/588316
Reviewed-by: Than McIntosh <thanm@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
src/cmd/cgo/internal/testshared/testdata/depBase/dep.go
src/cmd/link/internal/ld/deadcode.go