]> Cypherpunks repositories - gostls13.git/commit
runtime/pprof: assert that labels never appear on unexpected samples
authorMichael Pratt <mpratt@google.com>
Tue, 7 Dec 2021 17:01:04 +0000 (12:01 -0500)
committerMichael Pratt <mpratt@google.com>
Wed, 19 Jan 2022 16:33:11 +0000 (16:33 +0000)
commit985d97e602cb39c7739c072250e09ba61e440318
tree6e7a7fd468f29f76a6a2a6bb6ae53f598c956b8d
parent3e45eb3ce1f28ccb6e4150b6c2c09ca8568874e6
runtime/pprof: assert that labels never appear on unexpected samples

This makes TestLabelSystemstack much more strict, enabling it to detect
any misplacement of labels.

Unfortunately, there are several edge cases where we may not have an
obviously correct stack trace, so we generally except the runtime
package, with the exception of background goroutines that we know should
not be labeled.

For #50007
For #50032

Change-Id: I8dce7e7da04f278ce297422227901efe52782ca0
Reviewed-on: https://go-review.googlesource.com/c/go/+/369984
Trust: Michael Pratt <mpratt@google.com>
Run-TryBot: Michael Pratt <mpratt@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Austin Clements <austin@google.com>
src/runtime/pprof/pprof_test.go