]> Cypherpunks repositories - gostls13.git/commit
[dev.fuzz] internal/fuzz: improve handling of worker termination by signal
authorJay Conrod <jayconrod@google.com>
Wed, 7 Jul 2021 23:27:22 +0000 (16:27 -0700)
committerJay Conrod <jayconrod@google.com>
Thu, 8 Jul 2021 16:39:05 +0000 (16:39 +0000)
commit988d0248b404a82d8f5c5973610e8a56bffb38f4
treea067d2d2baf90ffea921a6cd3eacdee12e40dae0
parent0cf1e16bac137735ad7af45ac84df3b0afb312e3
[dev.fuzz] internal/fuzz: improve handling of worker termination by signal

With this change, we'll no longer silently ignore terminations by
SIGKILL. We use SIGKILL to terminate unresponsive workers, but it can
also be delivered by the OOM killer.

When a worker is terminated by a signal not apparently due to a crash
or interruption (like SIGKILL or SIGHUP, as opposed to SIGSEGV), we'll
log a message, but we won't record a crash, since any given input is
not likely to reproduce this termination.

Fixes golang/go#46576

Change-Id: I6ef18a7cf5a457c7b9bc44cf5416378271216bfd
Reviewed-on: https://go-review.googlesource.com/c/go/+/333190
Trust: Jay Conrod <jayconrod@google.com>
Trust: Katie Hockman <katie@golang.org>
Run-TryBot: Jay Conrod <jayconrod@google.com>
Reviewed-by: Katie Hockman <katie@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
src/cmd/go/testdata/script/test_fuzz_non_crash_signal.txt [new file with mode: 0644]
src/internal/fuzz/sys_posix.go
src/internal/fuzz/sys_unimplemented.go
src/internal/fuzz/sys_windows.go
src/internal/fuzz/worker.go