]> Cypherpunks repositories - gostls13.git/commit
path,path/filepath: add Join examples with ".." components
authorAndrew Ekstedt <andrew.ekstedt@gmail.com>
Fri, 24 Jul 2020 19:48:30 +0000 (12:48 -0700)
committerRob Pike <r@golang.org>
Wed, 19 Aug 2020 00:10:22 +0000 (00:10 +0000)
commit98a0071a5363e307c2e284034f810378de3883dd
tree4da947f708d5ff763f0370e93b61c2eae1a63ba0
parent0941fc3f9ff43598d25fa6e964e7829a268102bf
path,path/filepath: add Join examples with ".." components

People sometimes expect Join to trim .. components from its arguments
before joining, and are surprised that it doesn't. This is bad if they
were relying on that assumed behaviour to prevent directory traversal
attacks.

While a careful reading of the documentation for Join and Clean
might dispel this notion, it is not obvious at first glance.

Add a case to the examples to nudge people in the right direction.

Updates #40373

Change-Id: Ib5792c12ba1000811a0c0eb77048196d0b26da60
Reviewed-on: https://go-review.googlesource.com/c/go/+/249177
Run-TryBot: Ian Lance Taylor <iant@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
Reviewed-by: Rob Pike <r@golang.org>
src/path/example_test.go
src/path/filepath/example_unix_test.go