]> Cypherpunks repositories - gostls13.git/commit
runtime: rename GODEBUG=profileruntimelocks to runtimecontentionstacks
authorMichael Pratt <mpratt@google.com>
Mon, 4 Dec 2023 19:28:30 +0000 (14:28 -0500)
committerGopher Robot <gobot@golang.org>
Wed, 6 Dec 2023 17:57:59 +0000 (17:57 +0000)
commit98fd8f5768169c1c9cc9ae20490bd1b63ea55461
treeacc533de3a51f9703553773e6c7e3b55d927a546
parent6e33a6376e5bbbfa34c72c34d61abcc3f5891772
runtime: rename GODEBUG=profileruntimelocks to runtimecontentionstacks

profileruntimelocks is new in CL 544195, but the name is deceptive. Even
with profileruntimelocks=0, runtime-internal locks are still profiled.
The actual difference is that call stacks are not collected. Instead all
contention is reported at runtime._LostContendedLock.

Rename this setting to runtimecontentionstacks to make its name more
aligned with its behavior.

In addition, for this release the default is profileruntimelocks=0,
meaning that users are fairly likely to encounter
runtime._LostContendedLock. Rename it to
runtime._LostContendedRuntimeLock in an attempt to make it more
intuitive that these are runtime locks, not locks in application code.

For #57071.

Change-Id: I38aac28b2c0852db643d53b1eab3f3bc42a43393
Reviewed-on: https://go-review.googlesource.com/c/go/+/547055
Reviewed-by: Michael Knyszek <mknyszek@google.com>
Auto-Submit: Michael Pratt <mpratt@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Rhys Hiltner <rhys@justin.tv>
src/runtime/extern.go
src/runtime/metrics_test.go
src/runtime/mprof.go
src/runtime/proc.go
src/runtime/runtime1.go