]> Cypherpunks repositories - gostls13.git/commit
Revert "runtime: use unsafe.Slice in getStackMap"
authorJosh Bleecher Snyder <josharian@gmail.com>
Tue, 5 Oct 2021 18:31:57 +0000 (11:31 -0700)
committerJosh Bleecher Snyder <josharian@gmail.com>
Tue, 5 Oct 2021 20:35:54 +0000 (20:35 +0000)
commit990c9c6cabad6a083ac67c591a38f73d00850da8
tree5e00a6e4ca4cfa50ea1faad7e6a15d624823c90b
parent113b52979f48331b611e0fe7dadff97d6393ca27
Revert "runtime: use unsafe.Slice in getStackMap"

This reverts commit golang.org/cl/352953.

Reason for revert: unsafe.Slice is considerably slower.
Part of this is extra safety checks (good), but most of it
is the function call overhead. We should consider open-coding it (#48798).

Impact of this change:

name                   old time/op  new time/op  delta
StackCopyWithStkobj-8  12.1ms ± 5%  11.6ms ± 3%  -4.03%  (p=0.009 n=10+8)

Change-Id: Ib2448e3edac25afd8fb55ffbea073b8b11521bde
Reviewed-on: https://go-review.googlesource.com/c/go/+/354090
Trust: Josh Bleecher Snyder <josharian@gmail.com>
Run-TryBot: Josh Bleecher Snyder <josharian@gmail.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
src/runtime/stack.go