]> Cypherpunks repositories - gostls13.git/commit
cmd/compile: increase nesting depth limit for type descriptors
authorRobert Griesemer <gri@golang.org>
Mon, 17 Dec 2018 22:42:29 +0000 (14:42 -0800)
committerRobert Griesemer <gri@golang.org>
Tue, 18 Dec 2018 00:13:58 +0000 (00:13 +0000)
commit99e4ddd053fada36038f7fd4e7220d789e30e48a
tree145ba07c77b70d710dc334088b6ad807d38efbef
parent32b879c674b46249dc3e1db48c0076f5c11aa7a4
cmd/compile: increase nesting depth limit for type descriptors

The formatting routines for types use a depth limit as primitive
mechanism to detect cycles. For now, increase the limit from 100
to 250 and file #29312 so we don't drop this on the floor.

Also, adjust some fatal error messages elsewhere to use
better formatting.

Fixes #29264.
Updates #29312.

Change-Id: Idd529f6682d478e0dcd2d469cb802192190602f6
Reviewed-on: https://go-review.googlesource.com/c/154583
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
src/cmd/compile/internal/gc/fmt.go
src/cmd/compile/internal/gc/iexport.go
src/cmd/compile/internal/gc/iimport.go
test/fixedbugs/issue29264.go [new file with mode: 0644]