]> Cypherpunks repositories - gostls13.git/commit
cmd/go: don't save sums for modules loaded for import resolution
authorJay Conrod <jayconrod@google.com>
Mon, 8 Jun 2020 22:06:11 +0000 (18:06 -0400)
committerJay Conrod <jayconrod@google.com>
Fri, 14 Aug 2020 21:04:12 +0000 (21:04 +0000)
commit9a759593d7a71b4c061fd9bd053bd79584c632dc
tree3b1e5df9e12173481ffefb0499cedbc1509b9b65
parent016e13df7475329c65524b2eabbc5207ceb4ee74
cmd/go: don't save sums for modules loaded for import resolution

modfetch.WriteGoSum now accepts a map[module.Version]bool parameter.
This is used to prevent some new sums from being saved to go.sum when
they would be removed by the next 'go mod tidy'. Previusly, sums were
saved for modules looked up during import resolution.

A new function, modload.TrimGoSum, is also introduced, which marks
sums for deletion. 'go mod tidy' now uses this. The new logic
distinguishes between go.mod sums and content sums, which lets 'go mod
tidy' delete sums for modules in the build graph but not the build
list.

Fixes #31580
Fixes #36260
Fixes #33008

Change-Id: I06c4125704a8bbc9969de05265967ec1d2e6d3e8
Reviewed-on: https://go-review.googlesource.com/c/go/+/237017
Run-TryBot: Jay Conrod <jayconrod@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Michael Matloob <matloob@golang.org>
Reviewed-by: Bryan C. Mills <bcmills@google.com>
src/cmd/go/internal/modcmd/init.go
src/cmd/go/internal/modcmd/tidy.go
src/cmd/go/internal/modfetch/fetch.go
src/cmd/go/internal/modload/init.go
src/cmd/go/testdata/script/mod_sum_lookup.txt [new file with mode: 0644]
src/cmd/go/testdata/script/mod_tidy_old.txt [new file with mode: 0644]