]> Cypherpunks repositories - gostls13.git/commit
os/exec: don't run TestExtraFiles if extra files were open for the test
authorIan Lance Taylor <iant@golang.org>
Wed, 13 Nov 2019 02:17:37 +0000 (18:17 -0800)
committerIan Lance Taylor <iant@golang.org>
Wed, 13 Nov 2019 15:34:28 +0000 (15:34 +0000)
commit9a9a9005058f7b678c9ef89ce49255528fb97a33
tree39db838f85875487338349d84edf15c04cbe14ff
parent759c5d8ba6a5da7ce2896a44ba27887532ee0a46
os/exec: don't run TestExtraFiles if extra files were open for the test

Our attempts to close existing open files are flaky. They will fail if,
for example, file descriptor 3 is open when the test binary starts.
Instead, report any such cases, and skip TestExtraFiles.

Updates #35469

Change-Id: I7caec083f3f4a31579bf28fc9c82ae89b1bde49a
Reviewed-on: https://go-review.googlesource.com/c/go/+/206939
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Reviewed-by: Bryan C. Mills <bcmills@google.com>
src/os/exec/exec_test.go