]> Cypherpunks repositories - gostls13.git/commit
[dev.link] cmd/link: stop renumbering files for pclntab generation
authorJeremy Faller <jeremy@golang.org>
Mon, 3 Aug 2020 17:19:46 +0000 (13:19 -0400)
committerJeremy Faller <jeremy@golang.org>
Wed, 12 Aug 2020 17:14:51 +0000 (17:14 +0000)
commit9ae8f71c9431d287893443fa2b7fbdb72a9b56a2
tree6fe9e3fe2f23d14cc21d85c9e8d91541545e8485
parentffa9f33803c424753e384508b2dc4e5b3a83974f
[dev.link] cmd/link: stop renumbering files for pclntab generation

Creates two new symbols: runtime.cutab, and runtime.filetab, and strips
the filenames out of runtime.pclntab_old.

All stats are for cmd/compile.

Time:
Pclntab_GC                   48.2ms ± 3%    45.5ms ± 9%     -5.47%  (p=0.004 n=9+9)

Alloc/op:
Pclntab_GC                   30.0MB ± 0%    29.5MB ± 0%     -1.88%  (p=0.000 n=10+10)

Allocs/op:
Pclntab_GC                    90.4k ± 0%     73.1k ± 0%    -19.11%  (p=0.000 n=10+10)

live-B:
Pclntab_GC                    29.1M ± 0%     29.2M ± 0%     +0.10%  (p=0.000 n=10+10)

binary sizes:
NEW: 18565600
OLD: 18532768

The size differences in the binary are caused by the increased size of
the Func objects, and (less likely) some extra alignment padding needed
as a result. This is probably the maximum increase in size we'll size
from the pclntab reworking.

Change-Id: Idd95a9b159fea46f7701cfe6506813b88257fbea
Reviewed-on: https://go-review.googlesource.com/c/go/+/246497
Run-TryBot: Jeremy Faller <jeremy@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Than McIntosh <thanm@google.com>
Reviewed-by: Austin Clements <austin@google.com>
src/cmd/link/internal/ld/data.go
src/cmd/link/internal/ld/link.go
src/cmd/link/internal/ld/pcln.go
src/cmd/link/internal/ld/symtab.go
src/debug/gosym/pclntab.go
src/runtime/runtime2.go
src/runtime/symtab.go