]> Cypherpunks repositories - gostls13.git/commit
cmd/go/internal/mvs: reverse the order of BuildListError.stack
authorBryan C. Mills <bcmills@google.com>
Fri, 24 Jul 2020 02:24:04 +0000 (22:24 -0400)
committerBryan C. Mills <bcmills@google.com>
Mon, 24 Aug 2020 20:25:55 +0000 (20:25 +0000)
commit9bcc5d20b6f2574e5b98822e0986a1cfa14032f6
treeb4523964159912968c482d5dac6e1dd09ae0df53
parent5a691927659d1057bb3be80087732b5df5889aca
cmd/go/internal/mvs: reverse the order of BuildListError.stack

When we print the stack from a BuildListError, we print the main
module first and the error last. That was the opposite of the order in
which in was stored in memory, leading to (arguably) more complex code
and (definitely) my own inability to reason about the contents of the
slice.

For now, it's still more convenient to construct the stack reversed,
so we do that and then reverse it before packing it into the error.

For #36460

Change-Id: I6312fb67b2ad9bf9b64071fe829854833208bad7
Reviewed-on: https://go-review.googlesource.com/c/go/+/244759
Run-TryBot: Bryan C. Mills <bcmills@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Jay Conrod <jayconrod@google.com>
src/cmd/go/internal/mvs/mvs.go