]> Cypherpunks repositories - gostls13.git/commit
runtime: disallow preemption during startTheWorld
authorAustin Clements <austin@google.com>
Fri, 15 May 2015 20:10:00 +0000 (16:10 -0400)
committerAustin Clements <austin@google.com>
Mon, 18 May 2015 14:55:31 +0000 (14:55 +0000)
commit9c44a41dd56660b7685da61bf1efb00cc7c1e198
tree7cd0a059c967058618c51b1e8e783b0023648d1c
parenta1da255aa0b962231d80e594abe300200e6b4c73
runtime: disallow preemption during startTheWorld

Currently, startTheWorld clears preemptoff for the current M before
starting the world. A few callers increment m.locks around
startTheWorld, presumably to prevent preemption any time during
starting the world. This is almost certainly pointless (none of the
other callers do this), but there's no harm in making startTheWorld
keep preemption disabled until it's all done, which definitely lets us
drop these m.locks manipulations.

Change-Id: I8a93658abd0c72276c9bafa3d2c7848a65b4691a
Reviewed-on: https://go-review.googlesource.com/10155
Reviewed-by: Russ Cox <rsc@golang.org>
src/runtime/heapdump.go
src/runtime/mstats.go
src/runtime/proc1.go