]> Cypherpunks repositories - gostls13.git/commit
cmd/asm: reject foo(SB)(AX) instead of silently treating as foo(SB)
authorRuss Cox <rsc@golang.org>
Sun, 24 Jan 2016 06:33:16 +0000 (01:33 -0500)
committerRuss Cox <rsc@golang.org>
Sun, 24 Jan 2016 20:21:45 +0000 (20:21 +0000)
commit9d6427d8992b05445029f95c9555820675dd2e3e
tree13e6a7cbf4661e0a157d484363d32670e39684a7
parent544f28a25ec9421d52bbdd7c6272b4f1d4067964
cmd/asm: reject foo(SB)(AX) instead of silently treating as foo(SB)

Add test for assembly errors, to verify fix.
Make sure invalid instruction errors are printed just once
(was printing them once per span iteration, so typically twice).

Fixes #13282.

Change-Id: Id5f66f80a80b3bc4832e00084b0a91f1afec7f8f
Reviewed-on: https://go-review.googlesource.com/18858
Reviewed-by: Rob Pike <r@golang.org>
src/cmd/asm/internal/asm/endtoend_test.go
src/cmd/asm/internal/asm/testdata/amd64error.s [new file with mode: 0644]
src/cmd/asm/main.go
src/cmd/compile/internal/gc/lex.go
src/cmd/internal/obj/link.go
src/cmd/internal/obj/x86/asm6.go