]> Cypherpunks repositories - gostls13.git/commit
cmd/compile: fix noopt builder, weird append case
authorKeith Randall <khr@google.com>
Mon, 4 Dec 2017 21:30:13 +0000 (13:30 -0800)
committerKeith Randall <khr@golang.org>
Mon, 4 Dec 2017 21:45:40 +0000 (21:45 +0000)
commit9d70b3ae04316c5753435dddee54fe7373502e09
treeafaf25caa62d3e63275eb63417a87f8ca64865c2
parent509ffb94caae3fd53130d318c013cac38a179976
cmd/compile: fix noopt builder, weird append case

Turn off append-to-itself optimization if optimizations are turned off.

This optimization triggered a bug when doing
  s = append(s, s)
where we write to the leftmost s before reading the rightmost s.

Update #17039

Change-Id: I21996532d20a75db6ec8d49db50cb157a1360b80
Reviewed-on: https://go-review.googlesource.com/81816
Run-TryBot: Keith Randall <khr@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Reviewed-by: David Chase <drchase@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
src/cmd/compile/internal/gc/ssa.go