]> Cypherpunks repositories - gostls13.git/commit
debug/dwarf: better handling for DW_FORM_indirect
authorThan McIntosh <thanm@google.com>
Wed, 14 Aug 2019 19:04:05 +0000 (15:04 -0400)
committerThan McIntosh <thanm@google.com>
Tue, 3 Sep 2019 18:35:32 +0000 (18:35 +0000)
commit9da7abd2ebd07d32484277adac75c45b66f504c1
tree4f8192326dd34a5df2b3de06e3ae677e9bd2f877
parent9f89edcd9668bb3b011961fbcdd8fc2796acba5d
debug/dwarf: better handling for DW_FORM_indirect

Fix a buglet in abbrev processing related to DW_FORM_indirect. When
reading an abbrev entry if we encounter an attribute with form
DW_FORM_indirect, leave the class as ClassUnknown, then when the
abbrev is walked during the reading of the DIE fill in the class based
on the value read at that point (code for handling DW_FORM_indirect
seems to be already partially in place in the DIE reader).

Updates #33488.

Change-Id: I9dc89abf5cc8d7ea96824c0011bef979de0540bf
Reviewed-on: https://go-review.googlesource.com/c/go/+/190158
Run-TryBot: Than McIntosh <thanm@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: David Chase <drchase@google.com>
src/debug/dwarf/entry.go
src/debug/dwarf/typeunit.go