]> Cypherpunks repositories - gostls13.git/commit
runtime/pprof: expand inlined frames in symbolized proto profiles
authorAustin Clements <austin@google.com>
Thu, 20 Apr 2017 19:54:12 +0000 (15:54 -0400)
committerAustin Clements <austin@google.com>
Mon, 15 May 2017 18:20:23 +0000 (18:20 +0000)
commit9e83c11fca44282e4b8b1e099f437f557b73b43e
tree49d03dd419bd2be568155423bd54731bc141f41d
parent1dc0f9696b743b10bf0b7b49780bee7f4756499b
runtime/pprof: expand inlined frames in symbolized proto profiles

Currently proto symbolization uses runtime.FuncForPC and assumes each
PC maps to a single frame. This isn't true in the presence of inlining
(even with leaf-only inlining this can get incorrect results).

Change PC symbolization to use runtime.CallersFrames to expand each PC
to all of the frames at that PC.

Change-Id: I8d20dff7495a5de495ae07f569122c225d433ced
Reviewed-on: https://go-review.googlesource.com/41256
Run-TryBot: Austin Clements <austin@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Michael Matloob <matloob@golang.org>
src/runtime/pprof/pprof.go
src/runtime/pprof/pprof_test.go
src/runtime/pprof/proto.go
src/runtime/pprof/protomem.go