]> Cypherpunks repositories - gostls13.git/commit
runtime/race: implement race detector for ppc64le
authorLynn Boger <laboger@linux.vnet.ibm.com>
Thu, 29 Mar 2018 15:15:18 +0000 (11:15 -0400)
committerBrad Fitzpatrick <bradfitz@golang.org>
Mon, 11 Jun 2018 17:45:36 +0000 (17:45 +0000)
commit9e9ff565cdef4ef4db2955f0e96c9e83d452b4af
treefed58dd34c434721d1c404c5507946d470dba416
parent1de0dcfc7b50a2e74e572374d3bbbf3d12d7ff4f
runtime/race: implement race detector for ppc64le

This adds the support to enable the race detector for ppc64le.

Added runtime/race_ppc64le.s to manage the calls from Go to the
LLVM tsan functions, mostly converting from the Go ABI to the
PPC64 ABI expected by Clang generated code.

Changed racewalk.go to call racefuncenterfp instead of racefuncenter
on ppc64le to allow the caller pc to be obtained in the asm code
before calling the tsan version.

Changed the set up code for racecallbackthunk so it doesn't use
the autogenerated save and restore of the link register since that
sequence uses registers inconsistent with the normal ppc64 ABI.

Made various changes to recognize that race is supported for
ppc64le.

Ensured that tls_g is updated and accessible from race_linux_ppc64le.s
so that the race ctx can be obtained and passed to tsan functions.

This enables the race tests for ppc64le in cmd/dist/test.go and
increases the timeout when running the benchmarks with the -race
option to avoid timing out.

Updates #24354, #23731

Change-Id: Ib97dc7ac313e6313c836dc7d2fb698f9d8fba3ef
Reviewed-on: https://go-review.googlesource.com/107935
Run-TryBot: Lynn Boger <laboger@linux.vnet.ibm.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Bryan C. Mills <bcmills@google.com>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
13 files changed:
src/cmd/compile/internal/gc/builtin.go
src/cmd/compile/internal/gc/builtin/runtime.go
src/cmd/compile/internal/gc/racewalk.go
src/cmd/dist/test.go
src/cmd/go/internal/work/init.go
src/cmd/internal/obj/ppc64/obj9.go
src/cmd/link/internal/ld/config.go
src/race.bash
src/runtime/asm_ppc64x.s
src/runtime/race.go
src/runtime/race/race.go
src/runtime/race_ppc64le.s [new file with mode: 0644]
src/runtime/tls_ppc64x.s