]> Cypherpunks repositories - gostls13.git/commit
cmd/compile: add indexed memory modification ops to amd64
authorKeith Randall <khr@golang.org>
Mon, 13 Apr 2020 16:59:20 +0000 (09:59 -0700)
committerKeith Randall <khr@golang.org>
Thu, 30 Apr 2020 17:21:31 +0000 (17:21 +0000)
commit9ed0fb42e34ff64dd6447572d8bc9dbb05ddb552
treee59e3546819c8202237f0b911b5adad7f48040cb
parent882ec701d2bc5df807637418d726f644ed2e0ef6
cmd/compile: add indexed memory modification ops to amd64

name            old time/op  new time/op  delta
Modify-16        404ns ± 1%   365ns ± 1%  -9.73%  (p=0.000 n=10+10)
ConstModify-16   407ns ± 0%   385ns ± 2%  -5.56%  (p=0.000 n=9+10)

Seems to generally help generated code.

Binary size change is in the noise.

Change-Id: I57891bfaf0f7dfc5d143bb9f7ebafc7079d2614f
Reviewed-on: https://go-review.googlesource.com/c/go/+/228098
Reviewed-by: Josh Bleecher Snyder <josharian@gmail.com>
src/cmd/compile/internal/amd64/ssa.go
src/cmd/compile/internal/gc/bench_test.go
src/cmd/compile/internal/ssa/addressingmodes.go
src/cmd/compile/internal/ssa/gen/AMD64Ops.go
src/cmd/compile/internal/ssa/opGen.go
test/codegen/memops.go