]> Cypherpunks repositories - gostls13.git/commit
runtime: fix line number for faulting instructions
authorKeith Randall <khr@google.com>
Mon, 23 Sep 2019 21:36:48 +0000 (14:36 -0700)
committerKeith Randall <khr@golang.org>
Fri, 8 Nov 2019 21:05:17 +0000 (21:05 +0000)
commit9ee6ba089dc9dd2402bccd9ed28b07140f76de15
tree49f74474a7613c22e062d96cd3d33b21eb4a4380
parent9e914f55dded9f779aae86cfb2e989bc9a1d3ea4
runtime: fix line number for faulting instructions

Unlike function calls, when processing instructions that directly
fault we must not subtract 1 from the pc before looking up the
file/line information.

Since the file/line lookup unconditionally subtracts 1, add 1 to
the faulting instruction PCs to compensate.

Fixes #34123

Change-Id: Ie7361e3d2f84a0d4f48d97e5a9e74f6291ba7a8b
Reviewed-on: https://go-review.googlesource.com/c/go/+/196962
Run-TryBot: Keith Randall <khr@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Emmanuel Odeke <emm.odeke@gmail.com>
src/runtime/pprof/proto.go
src/runtime/pprof/proto_test.go
src/runtime/traceback.go
test/fixedbugs/issue34123.go [new file with mode: 0644]