]> Cypherpunks repositories - gostls13.git/commit
cmd/compile: refactor variadac call desugaring
authorMatthew Dempsky <mdempsky@google.com>
Tue, 21 Apr 2020 22:37:29 +0000 (15:37 -0700)
committerMatthew Dempsky <mdempsky@google.com>
Thu, 23 Apr 2020 06:24:40 +0000 (06:24 +0000)
commit9f4dd09bf555632a39a01a4c171e713acb55fda9
tree5f51a516d0893a152f0aa1665c5cdb04c9f4ba71
parent952f7de3b403d2ffb45708ea5f69168bbdbfe1f0
cmd/compile: refactor variadac call desugaring

In mid-Walk, we rewrite calls to variadic functions to use explicit
slice literals; e.g., rewriting f(a,b,c) into f([]T{a,b,c}...).
However, it would be useful to do that rewrite much earlier in the
compiler, so that other compiler passes can be simplified.

This CL refactors the rewrite logic into a new fixVariadicCall
function, which subsequent CLs can more easily move into earlier
compiler passes.

Passes toolstash-check -race.

Change-Id: I408e655f2d3aa00446a2e6accf8765abc3b16a8a
Reviewed-on: https://go-review.googlesource.com/c/go/+/229486
Run-TryBot: Matthew Dempsky <mdempsky@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Cuong Manh Le <cuong.manhle.vn@gmail.com>
src/cmd/compile/internal/gc/walk.go