]> Cypherpunks repositories - gostls13.git/commit
cmd/compile: ensure necessary types appear in .debug_info
authorDavid Chase <drchase@google.com>
Mon, 14 Nov 2016 23:00:17 +0000 (18:00 -0500)
committerDavid Chase <drchase@google.com>
Wed, 16 Nov 2016 22:05:19 +0000 (22:05 +0000)
commit9f5673d9307572ff3b435a845470e3b7fd3c6a43
treef4c0a4db2896b4c8776ec944d550d2cc772423fe
parent1e3c57c2cc1500b12a35a859f3d6e8aa27aeebc5
cmd/compile: ensure necessary types appear in .debug_info

Autotmp filtering was too aggressive and excluded types
necessary to make debuggers work properly.  Restore the
"late filter" in dwarf.go based on names to exclude autotmps,
and remove the "early filter" in pgen.go based on how the
name was introduced.  However, the updated naming scheme
with a dot prefix is retained to prevent accidental clashes
with legal Go identifier names.

Includes test (grouped with runtime gdb tests),
verified to fail without the fix.

Updates #17644.
Fixes #17830.

Change-Id: I7ec3f7230083889660236e5f6bc77ba5fe434e93
Reviewed-on: https://go-review.googlesource.com/33233
Run-TryBot: David Chase <drchase@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Matthew Dempsky <mdempsky@google.com>
src/cmd/compile/internal/gc/pgen.go
src/cmd/internal/dwarf/dwarf.go
src/runtime/runtime-gdb_test.go