]> Cypherpunks repositories - gostls13.git/commit
[release-branch.go1.5] runtime: improve stack barrier debugging
authorAustin Clements <austin@google.com>
Mon, 23 Nov 2015 16:29:56 +0000 (11:29 -0500)
committerRuss Cox <rsc@golang.org>
Tue, 24 Nov 2015 01:33:14 +0000 (01:33 +0000)
commit9f9b95bb59176d4b9e381265ea49a8fe15a5f3c1
tree53f136b3ad4977e173bf83985b3f87825cc9dbb3
parent3facf7ecebdf10fbd48a87aabd688082c567b78c
[release-branch.go1.5] runtime: improve stack barrier debugging

This improves stack barrier debugging messages in various ways:

1) Rather than printing only the remaining stack barriers (of which
   there may be none, which isn't very useful), print all of the G's
   stack barriers with a marker at the position the stack itself has
   unwound to and a marker at the problematic stack barrier (where
   applicable).

2) Rather than crashing if we encounter a stack barrier when there are
   no more stkbar entries, print the same debug message we would if we
   had encountered a stack barrier at an unexpected location.

Hopefully this will help with debugging #12528.

Change-Id: I2e6fe6a778e0d36dd8ef30afd4c33d5d94731262
Reviewed-on: https://go-review.googlesource.com/17147
Reviewed-by: Rick Hudson <rlh@golang.org>
Reviewed-by: Russ Cox <rsc@golang.org>
Reviewed-on: https://go-review.googlesource.com/17193
Run-TryBot: Austin Clements <austin@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
src/runtime/mgcmark.go
src/runtime/traceback.go