]> Cypherpunks repositories - gostls13.git/commit
crypto/x509: permit serial numbers to be negative.
authorAdam Langley <agl@golang.org>
Fri, 27 Nov 2015 21:50:36 +0000 (13:50 -0800)
committerAdam Langley <agl@golang.org>
Sat, 28 Nov 2015 00:07:16 +0000 (00:07 +0000)
commita0ea93dea5f5741addc8c96b7ed037d0e359e33f
tree4abe5c4a35e7cd6100fc455e6b3698472faefe3a
parent85bfa33fdc02417cadf46b3f185784e1cf7886b3
crypto/x509: permit serial numbers to be negative.

Some software that produces certificates doesn't encode integers
correctly and, about half the time, ends up producing certificates with
serial numbers that are actually negative.

This buggy software, sadly, appears to be common enough that we should
let these errors pass. This change allows a Certificate.SerialNumber to
be negative.

Fixes #8265.

Change-Id: Ief35dae23988fb6d5e2873e3c521366fb03c6af4
Reviewed-on: https://go-review.googlesource.com/17247
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
src/crypto/x509/x509.go
src/crypto/x509/x509_test.go