]> Cypherpunks repositories - gostls13.git/commit
runtime: publish netpoll info after incrementing fdseq
authorIan Lance Taylor <iant@golang.org>
Tue, 16 May 2023 23:03:38 +0000 (16:03 -0700)
committerGopher Robot <gobot@golang.org>
Wed, 17 May 2023 20:12:00 +0000 (20:12 +0000)
commita1674f3ee30bf46d22fcac115529ce830f8c9ac9
treedc71025bd11a51a2d2233b6bb84314578f59f1be
parent8c822ac7e8e136f079359be1772c1ba3f06399e6
runtime: publish netpoll info after incrementing fdseq

I think there is a theoretical possibility of a mistake before this CL.
pollCache.free would increment fdseq, but would not update atomicInfo.
The epoll code could compare to fdseq before the increment, but suspend
before calling setEventErr. The pollCache could get reallocated,
and pollOpen could clear eventErr. Then the setEventErr could continue
and set it again. Then pollOpen could call publishInfo.

Avoid this rather remote possibility by calling publishInfo after
incrementing fdseq. That ensures that delayed setEventErr will not
modify the eventErr flag.

Fixes #60133

Change-Id: I69e336535312544690821c9fd53f3023ff15b80c
Reviewed-on: https://go-review.googlesource.com/c/go/+/495297
Run-TryBot: Ian Lance Taylor <iant@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Ian Lance Taylor <iant@google.com>
Run-TryBot: Ian Lance Taylor <iant@google.com>
Reviewed-by: Bryan Mills <bcmills@google.com>
Auto-Submit: Ian Lance Taylor <iant@google.com>
src/runtime/netpoll.go