]> Cypherpunks repositories - gostls13.git/commit
test: deflake chan/select3.go
authorJosh Bleecher Snyder <josharian@gmail.com>
Fri, 7 Jul 2017 23:09:20 +0000 (13:09 -1000)
committerJosh Bleecher Snyder <josharian@gmail.com>
Sat, 8 Jul 2017 02:10:12 +0000 (02:10 +0000)
commita1e7fb4eed7fbb002d2fabbd6a809a1a49dca711
tree2d9099210b76b4081f9b0942c6b7f07f29950413
parent093adeef4004fd029de1a8fd138802607265dc73
test: deflake chan/select3.go

On a slow or distracted machine, 0.1s is sometimes
not long enough for a non-blocking function call to complete.
This causes rare test flakes.
They can be easily reproduced by reducing the wait time to (say) 100ns.

For non-blocking functions, increase the window from 100ms to 10s.
Using different windows for block and non-blocking functions,
allows us to reduce the time for blocking functions.
The risk here is false negatives, but that risk is low;
this test is run repeatedly on many fast machines,
for which 10ms is ample time.
This reduces the time required to run the test by a factor of 10,
from ~1s to ~100ms.

Fixes #20299

Change-Id: Ice9a641a66c6c101d738a2ebe1bcb144ae3c9916
Reviewed-on: https://go-review.googlesource.com/47812
Run-TryBot: Josh Bleecher Snyder <josharian@gmail.com>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
test/chan/select3.go