]> Cypherpunks repositories - gostls13.git/commit
[release-branch.go1.16] cmd/compile: correct type of pointer difference on RISCV64
authorCherry Mui <cherryyz@google.com>
Mon, 14 Feb 2022 17:43:27 +0000 (12:43 -0500)
committerDmitri Shuralyov <dmitshur@golang.org>
Fri, 18 Feb 2022 00:51:15 +0000 (00:51 +0000)
commita222963bc4c6f370a6d3bbf3954447433317b689
tree9deb0a98d4d79bc07fa733f07463a6a11d40df95
parent8a24f67ca73fc275646d768c66566af064f7ae09
[release-branch.go1.16] cmd/compile: correct type of pointer difference on RISCV64

Pointer comparison is lowered to the following on RISCV64

(EqPtr x y) => (SEQZ (SUB <x.Type> x y))

The difference of two pointers (the SUB) should not be pointer
type. Otherwise it can cause the GC to find a bad pointer.

Updates #51101.
Fixes #51198.

Change-Id: I7e73c2155c36ff403c032981a9aa9cccbfdf0f64
Reviewed-on: https://go-review.googlesource.com/c/go/+/385655
Trust: Cherry Mui <cherryyz@google.com>
Run-TryBot: Cherry Mui <cherryyz@google.com>
Reviewed-by: Keith Randall <khr@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
(cherry picked from commit 1ed30ca537a05b887f8479027b6363a03f957610)
Reviewed-on: https://go-review.googlesource.com/c/go/+/386475
src/cmd/compile/internal/ssa/gen/RISCV64.rules
src/cmd/compile/internal/ssa/rewriteRISCV64.go
test/fixedbugs/issue51101.go [new file with mode: 0644]