]> Cypherpunks repositories - gostls13.git/commit
encoding/asn1: error instead of panic on invalid value to Unmarshal
authorKimMachineGun <geon0250@gmail.com>
Tue, 29 Sep 2020 10:03:38 +0000 (10:03 +0000)
committerFilippo Valsorda <filippo@golang.org>
Tue, 29 Sep 2020 10:31:59 +0000 (10:31 +0000)
commita28edbfca276307b228eb4b154bc2d137a3cba4a
tree7a364b1e10eef488549543a4c7bee6771b4351f3
parent79e681d2a291142aa0ac8297229e182b2d1a78ac
encoding/asn1: error instead of panic on invalid value to Unmarshal

Changes Unmarshal to return an error, instead of
panicking when its value is nil or not a pointer.

This change matches the behavior of other encoding
packages like json.

Fixes #41509.

Change-Id: I92c3af3a960144566e4c2b55d00c3a6fe477c8d5
GitHub-Last-Rev: c668b6e4ad826f84542c2675eb31ccfb010c45bb
GitHub-Pull-Request: golang/go#41485
Reviewed-on: https://go-review.googlesource.com/c/go/+/255881
Run-TryBot: Emmanuel Odeke <emm.odeke@gmail.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Emmanuel Odeke <emm.odeke@gmail.com>
Reviewed-by: Filippo Valsorda <filippo@golang.org>
Trust: Emmanuel Odeke <emm.odeke@gmail.com>
src/encoding/asn1/asn1.go
src/encoding/asn1/asn1_test.go