]> Cypherpunks repositories - gostls13.git/commit
cmd/internal/obj/x86: fix ANDPS encoding
authorDamien Lespiau <damien.lespiau@intel.com>
Fri, 28 Apr 2017 14:20:38 +0000 (15:20 +0100)
committerBrad Fitzpatrick <bradfitz@golang.org>
Mon, 1 May 2017 18:32:52 +0000 (18:32 +0000)
commita2da2108ee18a338cdcdea5e319156858031af08
tree8c5892a166b4831da9e4bb63c55ec01cd3bb2f94
parentd1b544c7eb00d54d7298292c1860a965ecc93d41
cmd/internal/obj/x86: fix ANDPS encoding

ANDPS, like all others PS (Packed Single precision floats) instructions,
need Ym: they don't use the 0x66 prefix.

From the manual:

    NP 0F 54 /r        ANDPS xmm1, xmm2/m128

NP meaning, quoting the manual:

  NP - Indicates the use of 66/F2/F3 prefixes (beyond those already part
  of the instructions opcode) are not allowed with the instruction.

And indeed, the same instruction prefixed by 0x66 is ANDPD.

Updates #14069

Change-Id: If312a6f1e77113ab8c0febe66bdb1b4171e41e0a
Reviewed-on: https://go-review.googlesource.com/42090
Reviewed-by: Keith Randall <khr@golang.org>
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
src/cmd/asm/internal/asm/testdata/amd64enc.s
src/cmd/internal/obj/x86/asm6.go