]> Cypherpunks repositories - gostls13.git/commit
cmd/internal/obj: drop Filesym from DwarfAbstractFunc
authorMichael Pratt <mpratt@google.com>
Fri, 16 Dec 2022 18:43:16 +0000 (13:43 -0500)
committerGopher Robot <gobot@golang.org>
Mon, 30 Jan 2023 16:41:53 +0000 (16:41 +0000)
commita34cec8e411a2599ca7d2373dd2773aec25634ea
treeafeb5e9c1ec0030f0b76f7750a8e2c791b33602b
parent8c347a093cf168aa714da07f4d0709aa6d5a090d
cmd/internal/obj: drop Filesym from DwarfAbstractFunc

PutAbstractFunc doesn't use FnState.Filesym, so it isn't needed, but
more importantly it is misleading. DwarfAbstractFunc is frequently used
on inlined functions from outside the current compilation unit. For
those function, ctxt.fileSymbol returns nil, meaning it probably isn't
safe to use if the original compilation unit could also generate an
abstract func with the correct file symbol.

Change-Id: I0e6c76e41d75ac9ca07e0f775e49d791249e1c5d
Reviewed-on: https://go-review.googlesource.com/c/go/+/458198
Reviewed-by: Than McIntosh <thanm@google.com>
Auto-Submit: Michael Pratt <mpratt@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Run-TryBot: Michael Pratt <mpratt@google.com>
src/cmd/internal/obj/dwarf.go