]> Cypherpunks repositories - gostls13.git/commit
gofmt: don't crash when rewriting nil interfaces in AST.
authorRobert Griesemer <gri@golang.org>
Thu, 14 Apr 2011 21:25:25 +0000 (14:25 -0700)
committerRobert Griesemer <gri@golang.org>
Thu, 14 Apr 2011 21:25:25 +0000 (14:25 -0700)
commita49e7f393fe62d97dae691fdada7ab134fb83b6b
tree9cd9af88c525448ab36ada9f898d483fdef9676c
parent881b1b4a025486d90a2d9caf6f7a3a7634a93c6d
gofmt: don't crash when rewriting nil interfaces in AST.

The new reflection API makes it an error to call value.Set(x)
if x is invalid. Guard for it.

Added corresponding test case.

Fixes #1696.

R=rsc, r
CC=golang-dev
https://golang.org/cl/4398047
src/cmd/gofmt/gofmt_test.go
src/cmd/gofmt/rewrite.go
src/cmd/gofmt/testdata/rewrite1.golden
src/cmd/gofmt/testdata/rewrite1.input
src/cmd/gofmt/testdata/rewrite2.golden [new file with mode: 0644]
src/cmd/gofmt/testdata/rewrite2.input [new file with mode: 0644]