]> Cypherpunks repositories - gostls13.git/commit
cmd/link: skip fallocate test if not supported, and adjust allocation size on darwin
authorCherry Zhang <cherryyz@google.com>
Tue, 30 Jun 2020 20:51:27 +0000 (16:51 -0400)
committerCherry Zhang <cherryyz@google.com>
Wed, 1 Jul 2020 15:29:29 +0000 (15:29 +0000)
commita4ba411b19fa0111a3c8fe059fcf5489d3bd6bbf
treef3d8837a0878a75aa2200475b10148bf746cb94e
parent7799756a50f0a4070d66c67e9615375f852f2c04
cmd/link: skip fallocate test if not supported, and adjust allocation size on darwin

On Linux, the linker uses fallocate to preallocate the output
file storage. The underlying file system may not support
fallocate, causing the test to fail. Skip the test in this case.

On darwin, apparently F_PREALLOCATE allocates from the end of the
allocation instead of the logical end of the file. Adjust the
size calculation.

Fixes #39905.

Change-Id: I01e676737fd2619ebbdba05c7cf7f424ec27de35
Reviewed-on: https://go-review.googlesource.com/c/go/+/240618
Reviewed-by: Than McIntosh <thanm@google.com>
Run-TryBot: Cherry Zhang <cherryyz@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
src/cmd/link/internal/ld/fallocate_test.go
src/cmd/link/internal/ld/outbuf_darwin.go