]> Cypherpunks repositories - gostls13.git/commit
[release-branch.go1.18] internal/fuzz: fix TestUnmarshalMarshal on MIPS
authorRoland Shoemaker <roland@golang.org>
Sat, 5 Mar 2022 16:47:33 +0000 (08:47 -0800)
committerDmitri Shuralyov <dmitshur@golang.org>
Tue, 8 Mar 2022 00:41:50 +0000 (00:41 +0000)
commita54f962c29549f343a6b10559e14ca4d690cdb76
treebe9fc156336e7653f6eea380965cbd5be5c3391d
parent7f9a85f2d9bffbdd784eb208c4c45a7e4720f262
[release-branch.go1.18] internal/fuzz: fix TestUnmarshalMarshal on MIPS

Previous value used in the float32 roundtrip used float32(math.NaN())-1
which caused the quiet/signal bit to flip, which seemed to break the
test on MIPS platforms. Instead switch to using float32(math.NaN())+1,
which preserves the bit and makes the test happy.

Possibly related to #37455
Fixes #51258

Change-Id: Ia85c649e89a5d02027c0ec197f0ff318aa819c19
Reviewed-on: https://go-review.googlesource.com/c/go/+/390214
Trust: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Bryan Mills <bcmills@google.com>
Trust: Roland Shoemaker <roland@golang.org>
Run-TryBot: Roland Shoemaker <roland@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
(cherry picked from commit 63bd6f68e6cbb237b46a99775103758afaee370a)
Reviewed-on: https://go-review.googlesource.com/c/go/+/390418
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
src/internal/fuzz/encoding_test.go