]> Cypherpunks repositories - gostls13.git/commit
cmd/asm: simplify golden test maintenance
authorRuss Cox <rsc@golang.org>
Tue, 5 Jan 2016 14:48:45 +0000 (09:48 -0500)
committerRuss Cox <rsc@golang.org>
Sun, 24 Jan 2016 05:00:04 +0000 (05:00 +0000)
commita5ba581ae05a857a7828c5a883fab0d73a89f26d
tree9d89510a93953598793c8c15434dc125106cb89b
parente8b53c92b8086af8c5f279c795951a9aa1a14d58
cmd/asm: simplify golden test maintenance

Instead of two parallel files that look almost identical,
mark the expected differences in the original file.

The annotations being added here keep the tests passing,
but they also make clear a number of printing or parsing
errors that were not as easily seen when the data was
split across two files.

Fix a few diagnostic problems in cmd/internal/obj as well.

A step toward #13822.

Change-Id: I997172681ea6fa7da915ff0f0ab93d2b76f8dce2
Reviewed-on: https://go-review.googlesource.com/18823
Run-TryBot: Russ Cox <rsc@golang.org>
Reviewed-by: Rob Pike <r@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
19 files changed:
src/cmd/asm/internal/arch/arm.go
src/cmd/asm/internal/asm/asm.go
src/cmd/asm/internal/asm/endtoend_test.go
src/cmd/asm/internal/asm/testdata/386.out [deleted file]
src/cmd/asm/internal/asm/testdata/386.s
src/cmd/asm/internal/asm/testdata/amd64.out [deleted file]
src/cmd/asm/internal/asm/testdata/amd64.s
src/cmd/asm/internal/asm/testdata/arm.out [deleted file]
src/cmd/asm/internal/asm/testdata/arm.s
src/cmd/asm/internal/asm/testdata/arm64.out [deleted file]
src/cmd/asm/internal/asm/testdata/arm64.s
src/cmd/asm/internal/asm/testdata/mips64.out [deleted file]
src/cmd/asm/internal/asm/testdata/mips64.s
src/cmd/asm/internal/asm/testdata/ppc64.out [deleted file]
src/cmd/asm/internal/asm/testdata/ppc64.s
src/cmd/internal/obj/arm/anames5.go
src/cmd/internal/obj/arm/asm5.go
src/cmd/internal/obj/arm64/a.out.go
src/cmd/internal/obj/arm64/anames.go