]> Cypherpunks repositories - gostls13.git/commit
net/http: remove arbitrary timeouts from TestIdentityResponse and TestTLSHandshakeTimeout
authorBryan C. Mills <bcmills@google.com>
Fri, 27 Mar 2020 16:11:21 +0000 (12:11 -0400)
committerBryan C. Mills <bcmills@google.com>
Fri, 27 Mar 2020 18:16:46 +0000 (18:16 +0000)
commita5d1a9df812706708da1940898cf8cad8d5f9de2
tree1bef29d77157ed5f2b3dc67f54aabf289f7b4be4
parent0cc1290174751971d282196e21ec9037b217e5a5
net/http: remove arbitrary timeouts from TestIdentityResponse and TestTLSHandshakeTimeout

These hard-coded timeouts make the tests flaky on slow builders (such
as solaris-amd64-oraclerel), and make test failures harder to diagnose
anyway (by replacing dumps of the stuck goroutine stacks with failure
messages that do not describe the stuck goroutines). Eliminate them
and simplify the tests.

Fixes #37327
Fixes #38112

Change-Id: Id40febe349d134ef53c702e36199bfbf2b6468ff
Reviewed-on: https://go-review.googlesource.com/c/go/+/225977
Run-TryBot: Bryan C. Mills <bcmills@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
src/net/http/serve_test.go